Engineering Meeting Minutes

From 0L Network Handbook
Jump to navigation Jump to search

This page was built to accumulate the minutes from the Analytics Working Group meetings and make them available to the public. The contents are organized chronologically, with the most recent meeting first.

May 2022[edit | edit source]

23 May 2022[edit | edit source]

Attendees: @zmanian | iqlusion @ricoflan @0D | 0o-de-lally @Daniyal @shashank @coin1111 @Wade | TPT @Adal

(1) Bridge:

  • Progress has been made. As the MVP is nearing completion, we need to ideally have a working testnet to deploy the contracts to.
  • If help is available from others it could be utilized in the following areas
    • escrow contract
    • bundling signatures
  • The bridge is currently set up to be a multisig. How do we determine the ~5 validators controling the multisig? It was suggested it could be an algorithm randomly determining the validators for a given epoch range .
  • Concerns were mentioned about having/needing a market making service once the bridge is active. It was determined that this is out of the scope of the project and is a regulatory grey area. Genesis validators should not/would not be facilitating this. It is up to other token holders what they do with their coins. More concerns were brought up about fake markets being created and not having clear communication regarding a market that is made as it would need to be done by community members.

(2) Tower Game(VDF) :

  • The VDF tower game is taking a lot of engineering resources. It is also a main contributing factor to network stability. 0L as a community needs to decide if this is still relevant.
  • There was a split between the thinking that the game had run its course and could not scale as it is. Others would like to modify it and see if can be lower to reduce compute overhead.
  • The conclusion was that we would most likely implement the changes from work that had already been done but we would like to put a call out to members of the community to start thinking about different ideas for mechanisms that could replace towers as 0L's growth story.

(3) Anticipated Changes Incoming:

  • Two PR's are going to be circulated(already have as of today).
  • The goal is to factor in feedback from the community regarding Proof to exist and helping to get past the cycling problem we are having at ~40 validators
    • https://github.com/OLSF/libra/pull/1118
    • https://github.com/OLSF/libra/pull/1119

April 2022[edit | edit source]

18 April 2022[edit | edit source]

Attendees: @ricoflan @Daniyal @keerthi @shashank @Wade | TPT @cjh247 @coin1111 @0D | 0o-de-lally @Adal @thenateway

Bridge

  • @coin1111 working on integration tests
  • Presently there is an agent without multi sig functionality that detects coins in blockchain and moves to another
  • Working to create integration tests to validate end 2 end
  • Next will potentially work on multisig functionality
  • Discussed potential Carpe plugin

Network Outage

  • When the network failed over it required more validators than are actually involved in the network
  • Should we just restart the network or make changes/fixes?
  • @0D | 0o-de-lally has started an experimental network where he is pulling in changes to the standard library (impementing Make Whole, Enabling Slow Wallets, Implementing Ancestry Analytics and make Proof of Burn more dynamic)
  • Potential options:
         * Take the the tip of the network, epoch 167, apply some right set tx's & you have a new genesis affect
         * Starting from scratch & spooning data from the last backup (e.g. getting balances back, etc
         * Option noted above by @0D | 0o-de-lally 

Vote:

  • Engineering WG voted to implement the changes noted by @0D | 0o-de-lally in the network restart namely: impementing Make Whole, Enabling Slow Wallets, Implementing Ancestry Analytics and make Proof of Burn more dynamic (with a 14 day delay specifically on the Proof of Burn item to allow a bit more time to community members to voice concerns)

4 April 2022[edit | edit source]

Attendees: @Ashiiix @coin1111 @cjh247 @MustyCRYP | MYRIA @ricoflan @shashank @drawks oups

Bridge:

  • @coin1111 is finishing buidling the coin transfer from both sides 0l to ETH and back and then will need to clean up & refactor
  • Need to work on the server framework
  • Need to start thinking about how we deploy it
  • How will we utilize a multi sig module
  • Eth is very expensive to deploy / use this bridge on, should we look at other EVM compatible chains to start (to help us bring in folks from other communities)? (BNB, MATIC, AVAX, Metis, etc)
  • Discussed batching as a potential solution

Make Whole

  • Smart contract review is ongoing
  • Needs to be deployed to testnet prior to going on mainnet, causing some delay

Carpe App

  • Working on translations to other languages
  • @ricoflan has reached out to the translators and items appear on track
  • Move to Diem 1.4 has an engineer scoping the work and getting us ready to go down this path
  • Wallet transfer are not yet released, we are working on the PR this week; regular QA process is ongoing
  • Note: We should note the steps for QA and the testnet process somewhere

March 2022[edit | edit source]

28 March 2022[edit | edit source]

Present: @dboreham, @ricoflan, @nibbler, @coin1111, @zmanian, @daniyal, @shashank, @Adal

  • @Coin1111 - Bridge Update
    • Was able to move coins on DevNet to ETH
    • Next step is to move the other way
    • Needs to create integration tests framework
    • After that, plans to add multis
  • @Adal - Carpe update
    • 2 new features ready to go: wallet type indicator and transfers
    • Timing?
      • Reach out to @ricoflan in advance for comms coordination
    • Ongoing fixes of minor UX issues
    • German version being readied
    • Italian translation underway
  • @Ashiix - not able to attend, so no update on the Make Whole this week
    • Will reach out to him for update in the WG channel
  • Bounty Payments
    • Up to date as far as Iqlusion Engineering Fund
    • FTW — how to get into monthly payments?
      • @zmanian co-runs with @0D
      • ToDo: Reach out to @0D to discuss this
  • ToDo: Reach out to 0D about the bug in validator onboarding
    • Will he take it on?
    • @zmanian think we can get this done with a hot Upgrade
  • Dev Roadmap?
    • Q: Is this the time to enable tokens on top of the chain?
    • Q: When should we move to the current version of Move?
      • This will require a network halt
      • Huge amount of work
      • @0D is likely the most qualified to do this
    • Short term Priorities
      • Make Whole
      • Wallet feature deployment
      • (Continued work on ETH Bridge)
    • Medium term
      • Revisit slow wallet restrictions
      • Get in step with current version of Move
        • @zmanian & @0D have an Engineer in mind to lead this work. @zmanian will reach out to 0D to discuss
  • TestNet start up continues to be problematic
    • Try to find an hour and get everyone together for startup
  • Brief discussion on needed feature to enable Move dev on chain
    • We should add publish move contract module support to the public txs

21 March 2022[edit | edit source]

Attendees: @dboreham, @ricoflan, @ashiix, @nibbler, @coin1111, @adal, @thenateway, @rydercrypt, @zmanian, @daniyal

  • Quick chat about Aptos, and how to engage positively with them on technical issues
  • Update from @coin1111 on Bridge project
    • Last week, finished work on wrappers for bridge escrow contracts
    • Now incorporating into Rust agent (~30% done)
    • Hopes that, by end of week, it will be possible for one agent to move funds from 0L to ETH
  • Update from @zmanian: Iqlusion Engineering Fund bounties paid this past weekend
  • Update from @adal on Carpe
    • Last week saw the release to testers of a new RC with 2 new features (multilingual and account events). The release also includes language support for French, Portuguese and Chinese
    • Bug fixes are ongoing
    • Wallet Type update
      • Testing missing — have reached out to devs
  • Make Whole? Need an update from @wade | TPT
  • Appears we have a bug in Validator Onboarding
    • @mortonbits has a suspect; tower height of inactive validators is being used to define validator set
    • Should be able to fix with a hot upgrade
    • Need a worker for this

14 March 2022[edit | edit source]

Attendees: @Ashiiix @cjh247 @Daniyal @ricoflan @shashank @zmanian | iqlusion @coin1111 @thenateway

Bridge

  • @coin1111 working on creating rust trackers to call into hardhat smart contracts (eth dev net)
  • Previously implemented simple agent using type script now doing it using rust
  • @Ashiiix / @coin1111 to sync up on some open items

Make Whole

  • Per @Ashiiix we have all necessary information but need to action it
  • Bounty to create a smart contract for this has been assigned

Teams Effort

  • Per @zmanian | iqlusion current issuance policy for gas tokens is not sustainable
  • Governance is wrapped up in this

Carpe App

  • We are expecting 2PR acceptance for the transfer functionality & to display the type of wallet

DevNet

  • Need @zmanian | iqlusion's help in adding a third person to github repo ( @Daniyal to send username of person to be added to genesis repo / Dev Genesis)

7 March 2022[edit | edit source]

Attendees: @Ashiiix @cjh247 @coin1111 @Daniyal dboreham @ricoflan @shashank @Adal

Bridge

  • Last week @coin1111 was working on an angent to transfer funds between accounts. He has built an initial version.
  • Next step is on Eth (to add transfer functionality on ethereum to a rust agent)
  • This will also involve changes to 0L & standard libraries

Teams Effort

  • Prior to releasing this we might want to improve documentation
  • @ricoflan asked if @Adal could share concerns he noted in the teams delegation channel

Make Whole

  • Follow up with @Wade | TPT if he knows the amount of rewards that would need to go to each wallet (if this analysis had been done)

Carpe App

  • Focused on bringing more data unto the app from the chain
  • Ideally we would include 'account statement' or 'account type with events', it is important for users to understand timeline of transfer
  • Wallet to wallet transfer is closed to being rolled out as a functionality

February 2022[edit | edit source]

28 Feb 2022[edit | edit source]

Present: @Wade, @zmanian, @ricoflan, @Ashiiix, @coin1111, @Daniyal, @ej-w, @thenateway

  • Round up of hustle karma tasks
  • Bridge Update, from @coin1111
    • Work is in progress,
    • Have created a proposal to a support call for workers on GitCoin
  • Make Whole & Slow Wallets:
    • The question was raised: Are these two issues priorities for the group?  Yes, was the conclusion.
    • Methodology needs to be sorted out for Make Whole
      • Preference seems to be for a Merkle tree based solution, but group feels the fastest solution is likely appropriate at this stage
      • @Wade to create a Mission for this; bounty to be sponsored by Iqlusion
    • Parameters need to be discussed re: slow wallet triggers & limits
      • Timing: This should trail the Carpe wallet update to add transaction ability
        • Need more reviewers of Carpe PR
      • Need to propose new parameters (release date and daily limits)
  • DevNet
    • still need one more node in the system.
    • Reach out to @thenateway if you are interested

21 February 2022[edit | edit source]

Present: @dboreham @Ashiiix @cjh247 @Daniyal @Wade | TPT @0D | 0o-de-lally @coin1111 @Adal @shashank @technique martin15781

Teams Upgrade

  • We are close to having 5 reviewers finish reviewing this proposal

Teams Phase 2

  • Discussed components that still need to be built related to sybil resistance (esp around identity towers)
  • One potential option discussed was looking at the ancestor/genesis of a wallet address (to avoid a synthetic creating a lot of addresses for themselves)
  • Presently missing a permission tree. A lot of this work would require Oracle functionality

Make Whole

  • Haven't made a lot of progress lately
  • Two options: putting hashes into a merkle tree and hard coding the merkle hash, or (the ugly way) hardcoding the addresses into a smart contract
  • Need more support here @Ashiiix to potentially bring/interview someone on for this role

Bridge

  • Exists on the ethereum and move side
  • Ethereum piece has been easier to develop due to extensive available tooling. We have a basic smart contract that allows you to transfer funds within eth blockchain and paramters to specify the address on the Move side (yet untested). Still working on an agent on the Move side.
  • @coin1111 could use some stand alone support on tasks that would require someone with a Rust background
  • @Wade | TPT / @coin1111 to coordinate to create an entry/issue on gitcoin

Carpe Beta

  • @Adal brought up a re-occuring issue happening in the Carpe UI that he thinks we should potentially look into

Testnet Node Runners

  • Still need 1 more volunteer

Project Board

  • Team looked through / discussed the board on github

14 February 2022[edit | edit source]

Present: @Wade | TPT @sof @Adal @thenateway @Daniyal @0D | 0o-de-lally @shashank @zmanian | iqlusion @Nour | N 𝕊pace @ricoflan

DEX Discussion

  • @zmanian | iqlusion raised that he and others were in discussions with the Phonon Network
  • There concept involves swaps of private keys using secure enclaves.
  • Seems like the SECP contract/functionality that we would need for this may have been created by @coin1111 already, but would need to be implemented via an upgrade; more dilligence needed if this is the case

Teams Upgrade

  • Need more reviewers (at various stages of reviewing are: @zmanian | iqlusion @Adal @shashank )

Bridge

  • @coin1111 has taken on portions of the Eth piece of the bridge.
  • @Wade | TPT created a gitcoin entry seeking solidity devs

Carpe Beta

  • @cjh247 to reach out to @ricoflan to see if he was able to reach out to Ping re: multi lingual support

Asks: Testnet

  • Need someone to run testnet nodes: should be able to be pulled off with 2 virtual cpus, 10gb RAM, 50 gb of disk.
  • Should we add a bounty for this? @Wade | TPT
  • @thenateway volunteered, still need 2 more volunteers

Epoch Archive Repo (Snapshot)

  • need more validators other than just @0D | 0o-de-lally doing this to add redundancy

Roles

  • Need someone to own the project board on github & make sure it is well formed
  • Need a coordinator to replace @0D | 0o-de-lally

7 February 2022[edit | edit source]

Present: @coin1111 @technique @Daniyal @0D | 0o-de-lally @Adal @zmanian | iqlusion @shashank @benzen @ricoflan

Follow-ups

  • @thenateway created github issue for 'Tokyo Error' but we still need to find a resolution to this issue
  • @coin1111 & @Wade | TPT to create gitcoin entry for Solidity Dev

Bridge

  • Discussed progress made on bridge work
  • Initial framework for Move portion of bridge involves Sender, Receiver and Escrow Account
  • Presently bullentin for aggregating signatures would live ina Move Contract (this raises some potential complexities)
  • @zmanian | iqlusion raised concerns on using the Gravity Bridge model, given how much of an effort it was for the IBC team to implement on Cosmos (years); and suggested we consider other potential bridge models
  • Need to further review design documentation & discuss

Carpe Beta

  • Running into minor issues, need to determine if this issue is in code or local machine config
  • Need better bug data from users, reproducibility is an issue
  • @ricoflan to reach out to Ping about multi lingual support

Teams

  • Some issues around how validators can or cannot remove themselves from validator set
  • 2 rollout phases. 1 - Implement option to enable teams. 2 - Make it mandatory and implements the ratchet
  • Phase 1 looks ready to, but need more eyes on to build certainty

Make Whole (MH)

  • @veeEmm exploring whether we can use the SMTree library as part of the MH Update & whether it supports classical merkle trees
  • @ricoflan to keep chasing analytics wg re: who needs to repaid and how much